Fix removal of multiple selected connections from browser #57800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new "QgsDataItemGuiProviderUtils" class, with a generic function for handling deletion of browser connection items. Replace all the duplicate connection deletion logic from the different browser connection providers with calls to the generic function. In addition to removing a lot of duplicate code, the new generic function correctly handles deletion of multiple selected connections (previously, only the first connection would actually be removed). Fixes qgis#26276
We unfortunately can't rely on the generic function for this particular connection type, because of complexities relating to GPKG connection items created as a result of scanning a folder for GPKG files vs user created/stored connections
nyalldawson
force-pushed
the
remove_multiple
branch
from
5cac30a to
400d002
Compare
elpaso
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new "QgsDataItemGuiProviderUtils" class, with a generic function for handling deletion of browser connection items.
Replace all the duplicate connection deletion logic from the different browser connection providers with calls to the generic function.
In addition to removing a lot of duplicate code, the new generic function correctly handles deletion of multiple selected connections (previously, only the first connection would actually be removed).
Fixes #26276